Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library version support #232

Merged
merged 2 commits into from
Jul 14, 2018
Merged

Conversation

corochann
Copy link
Member

resolves #192 and #231

@codecov-io
Copy link

codecov-io commented Jul 14, 2018

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         106      106           
  Lines        5114     5114           
=======================================
  Hits         4188     4188           
  Misses        926      926

Copy link
Member

@mottodora mottodora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mottodora mottodora merged commit a4407df into chainer:master Jul 14, 2018
@corochann corochann deleted the fix_version_support branch July 14, 2018 05:16
@mottodora mottodora added this to the 0.4.0 milestone Jul 18, 2018
@corochann corochann modified the milestones: 0.4.0, 0.5.0 Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a version comparison table
3 participants