-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crystal Support #396
Crystal Support #396
Conversation
…stry into megnet-1
refactor considering memory budget
Refactor converter
Use as_variable instead of isinstance
README.md
Outdated
@@ -127,6 +131,7 @@ The following datasets are currently supported: | |||
- Tox21 [9] | |||
- MoleculeNet [11] | |||
- ZINC (only 250k dataset) [12, 13] | |||
- Material Project (日付を入れる) [23] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO later
Codecov Report
@@ Coverage Diff @@
## experimental_mp #396 +/- ##
===================================================
- Coverage 91.3% 84.27% -7.04%
===================================================
Files 227 250 +23
Lines 10999 11951 +952
===================================================
+ Hits 10043 10072 +29
- Misses 956 1879 +923 |
I wrote tests for CGCNN & MEGNet. Currently, all tests pass the forward test, Now, most of the backward test are commented out and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let me check running the code.
""" | ||
|
||
# get atom feature vector | ||
# TODO: ここも適当なPATHに置き換える |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change __init__
method get data_dir
path in argument and load json & create feat_dict
inside __init__
?
Then we can re-use self.feat_dict in this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is experimental branch, so let me merge this PR at first.
I will proceed following:
- include changes of current master branch (dataset class are added to support converter)
- write download script of materials project dataset
- modify
data_dir
path etc.
- modify
- include citation/license properly
- check code runs
- merge to master branch
DONE
examples/test_example.sh
pytest -m "not (gpu or slow)" tests
The detail description is here
TODO