Support lazy evaluation for member access, item access and function call #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added general three types of exprs: - GetItem for __getitem__ method - GetAttr for __getattr__ method - Call for __call__ method Instead I removed speciall classes such as DTypeExpr and Shape. These classes are replaced with GetItem and GetAttr.
|
LGTM! |
beam2d
added a commit
that referenced
this pull request
Jul 6, 2015
Support lazy evaluation for member access, item access and function call
unnonouno
added
the
cat:enhancement
okuta
pushed a commit
to okuta/chainer
that referenced
this pull request
Jul 14, 2017
Implement cupy.lexsort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented
GetAttr,GetItem, andCallclasses which are sub-classes ofExpr. These classes evluate__getattr__,__getitem__and__call__inexpr. And old special classes likeShapeare replaced with combinations of these classes.For example this code is valid:
In this situation, first
Call(GetAttr(GetItem(Constant(...), 1), '__len__'), ())is created, and then it is evaluated.fix #131