-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added typecheck where self.__dict__ is used. #382
Conversation
Thank you for your PR.
Chainer project uses PEP8 and a part of OpenStack Style Guidelines related to general coding style. |
OK. Fixed. |
Fixed typecheck in _get_sorted_funcs. ('conv1b', <chainer.functions.convolution_2d.Convolution2D object at 0x7fc5a47295d0>) |
I think to be good to use |
I overlooked |
OK. I misunderstood. |
LGTM! |
Added typecheck where self.__dict__ is used.
It's about #381 .
To avoid error when self.dict contains something not function.