Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove input type consistency checks #4339

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented Feb 15, 2018

These codes are invalid as iDeep is now introduced.
Note that type consistency is now checked in FunctionNode level (#4029), so we can safely remove these checks.

Type check code in F.linear will be removed in #4278.

@niboshi
Copy link
Member

niboshi commented Feb 15, 2018

LGTM!

@niboshi niboshi merged commit 088a3c9 into chainer:master Feb 15, 2018
@niboshi niboshi added this to the v4.0.0b4 milestone Feb 15, 2018
@niboshi niboshi assigned niboshi and unassigned delta2323 Feb 15, 2018
@niboshi niboshi added the cat:enhancement Implementation that does not break interfaces. label Feb 15, 2018
@niboshi
Copy link
Member

niboshi commented Feb 15, 2018

Not to be backported because #4029 has been merged only in master branch.

@kmaehashi kmaehashi deleted the remove-type-check branch February 15, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants