Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support step slicing on ONNX export #8484

Merged
merged 4 commits into from
Nov 29, 2019
Merged

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Nov 28, 2019

From opset11, Slice operator supports step input. Along with, add to check opset version when using GatherND.

@disktnk disktnk added the ONNX Related to ONNX label Nov 28, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 29, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit a6dfa2d, target branch master) succeeded!

@mergify mergify bot merged commit f23e8f4 into chainer:master Nov 29, 2019
@disktnk disktnk deleted the fix/getitem-step branch November 29, 2019 09:24
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:enhancement Implementation that does not break interfaces. label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces. ONNX Related to ONNX st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants