This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Sequential feature extractor remove_unused #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyu2172
force-pushed
the
sequential-feature-extractor-getitem
branch
from
c56f021
to
2173223
Compare
|
I merged #347. Could you merge master branch to this PR? |
|
Merge after #349 |
yuyu2172
force-pushed
the
sequential-feature-extractor-getitem
branch
from
63cd9da
to
982f2f6
Compare
yuyu2172
force-pushed
the
sequential-feature-extractor-getitem
branch
from
a518f21
to
b4fc033
Compare
yuyu2172
changed the title
Hakuyume
reviewed
Jul 22, 2017
|
|
||
| """ | ||
| if self._feature_names is None: | ||
| feature_names = (self.all_feature_names[-1],) |
There was a problem hiding this comment.
If _feature_names is None, we can simply use return to skip this method.
Hakuyume
reviewed
Jul 22, 2017
| delattr(ret, name) | ||
| return ret | ||
| def remove_unused(self): | ||
| """Delete all features that are not needed for the forward pass. |
There was a problem hiding this comment.
This function removes layers (function or link). I prefer Delete all layers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #347 .
I found that it is beneficial to have a method that chops off unnecessary part from a feature extractor.
For instance, an optimizer hook is called for all parameters even if they are not used in a computational graph.