Refactor MultiNodeIterator classes #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shu65
changed the title
kuenishi
requested changes
May 10, 2018
| raise RuntimeError('Multi node iterator supports numpy.float32 ' | ||
| 'or tuple of numpy.float32 as the data type ' | ||
| 'of the batch element only.') | ||
| else: |
There was a problem hiding this comment.
I don't think we need this else. Let's reduce indent level.
| # 3. whether dataset is paired. | ||
| # 4. is_new_epoch. | ||
| # 5. current_position. | ||
| _info = numpy.ones((5, )) \ |
There was a problem hiding this comment.
Given that this is a refactoring patch, I'd want this conversion as a symmetric functions for tests. Maybe we could increase the number of elements in future. Let's have unit tests for this conversions for future. Like this:
def _build_ctrl_msg(stop, is_valid_data_type, is_paired_dataset, is_new_epoch, current_pos):
...
def _parse_ctrl_msg(msg):
....
def test_msg_conversion():
msg = [....]
assert msg == _build_ctr_msg(_parse_ctrl_msg(msg))| @@ -117,23 +137,28 @@ def __next__(self): | |||
| # Check if master iterator received stop signal. | |||
| _info = self.communicator.bcast(None, root=self.rank_master) | |||
| stop = bool(_info[0]) | |||
| if stop: | ||
| raise StopIteration | ||
| elif not valid_data_type: | ||
| raise RuntimeError('Multi node iterator supports numpy.float32 ' |
There was a problem hiding this comment.
TypeError should be raised here.
Passing arguments of the wrong type (e.g. passing a list when an int is expected) should result in a TypeError,
| if stop: | ||
| raise StopIteration | ||
| elif not valid_data_type: | ||
| raise RuntimeError('Multi node iterator supports numpy.float32 ' |
kuenishi
approved these changes
May 10, 2018
This was referenced May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor two MultiNodeIterator classes.
I mainly did the following: