Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Atari Wrappers #349

Merged
merged 13 commits into from
Nov 14, 2018
Merged

Move Atari Wrappers #349

merged 13 commits into from
Nov 14, 2018

Conversation

prabhatnagarajan
Copy link
Contributor

This PR does the following:

  • Moves Atari wrappers into the chainerRL wrappers and calls new wrapper from example files
  • Other minor changes to examples

toslunar
toslunar reviewed Nov 12, 2018
View reviewed changes
chainerrl/wrappers/__init__.py Outdated
from chainerrl.wrappers.atari_wrappers import MaxAndSkipEnv # NOQA
from chainerrl.wrappers.atari_wrappers import EpisodicLifeEnv # NOQA
from chainerrl.wrappers.atari_wrappers import FireResetEnv # NOQA
from chainerrl.wrappers.atari_wrappers import NoopResetEnv # NOQA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these wrappers are specific to atari. I'd rather not make them available under chainerrl.wrappers.

toslunar
toslunar reviewed Nov 13, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge master and fix the use of atari_wrappers in the examples of BatchAgent?

toslunar
toslunar approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar self-assigned this Nov 14, 2018
@toslunar toslunar merged commit d99c1de into chainer:master Nov 14, 2018
@toslunar toslunar added this to the v0.5 milestone Nov 14, 2018
@prabhatnagarajan prabhatnagarajan deleted the prune_dqn_example branch November 14, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
enhancement
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhatnagarajan @toslunar @muupan