-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes PFN CI tests #605
Fixes PFN CI tests #605
Conversation
/test |
Successfully created a job for commit 3987d4d: |
/test |
Successfully created a job for commit 3987d4d: |
/test |
Successfully created a job for commit 7ea0292: |
/test |
Successfully created a job for commit 4a3a2c6: |
/test |
Successfully created a job for commit 347fe16: |
/test |
Successfully created a job for commit d54c60b: |
/test |
Successfully created a job for commit 7eb7d63: |
/test |
Successfully created a job for commit 8839092: |
/test |
Successfully created a job for commit d8ffda2: |
@@ -206,7 +206,6 @@ def make_env(idx, test): | |||
maxSteps=max_episode_steps, | |||
isTest=test, | |||
) | |||
assert env.observation_space is None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this line after this recent update to the environment: bulletphysics/bullet3@3a6a279#diff-37edfb1b0750fd6a650da86f2d5c1ec3827623de1abb22ba2fc7cf897eeb5c44
@@ -1,9 +1,6 @@ | |||
import argparse | |||
import os | |||
|
|||
# Prevent numpy from using multiple threads | |||
os.environ['OMP_NUM_THREADS'] = '1' # NOQA | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not move this line. This must be done before import numpy
.
examples/atari/train_a3c_ale.py
Outdated
@@ -1,9 +1,6 @@ | |||
import argparse | |||
import os | |||
|
|||
# Prevent numpy from using multiple threads | |||
os.environ['OMP_NUM_THREADS'] = '1' # NOQA | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
examples/atari/train_acer_ale.py
Outdated
@@ -1,9 +1,6 @@ | |||
import argparse | |||
import os | |||
|
|||
# Prevent numpy from using multiple threads | |||
os.environ['OMP_NUM_THREADS'] = '1' # NOQA | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
examples/atari/train_nsq_ale.py
Outdated
@@ -2,9 +2,6 @@ | |||
import os | |||
import random | |||
|
|||
# This prevents numpy from using multiple threads | |||
os.environ['OMP_NUM_THREADS'] = '1' # NOQA | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
examples/gym/train_a3c_gym.py
Outdated
@@ -12,9 +12,6 @@ | |||
import argparse | |||
import os | |||
|
|||
# This prevents numpy from using multiple threads | |||
os.environ['OMP_NUM_THREADS'] = '1' # NOQA | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
examples/gym/train_acer_gym.py
Outdated
@@ -1,9 +1,6 @@ | |||
import argparse | |||
import os | |||
|
|||
# This prevents numpy from using multiple threads | |||
os.environ['OMP_NUM_THREADS'] = '1' # NOQA | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
Can you explain why it needs python 3.6? |
Some of the previous PR CIs were failing:
I thought it would be ok to update the required version to 3.6 (at least for testing). |
/test |
Successfully created a job for commit 7b2fabb: |
/test |
Successfully created a job for commit 484f12e: |
/test |
Successfully created a job for commit c41db82: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While E402 can be addressed in a different way (https://gitlab.com/pycqa/flake8/-/issues/638), I think it is good to merge as it is since fixing the CI asap is important.
This fixes the build and changes the supported Python version to 3.6.