fix: use stderr for cli messages #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
approved these changes
Sep 19, 2023
| println!(); | ||
| println!("{}", keys); | ||
| println!("{}", DISCLAIMER); | ||
| eprintln!(); |
There was a problem hiding this comment.
Why not just use \n instead of the empty printlns?
There was a problem hiding this comment.
🤷 It's nicer to read? Keeps everything in line etc...
Codecov Report
@@ Coverage Diff @@
## main #4022 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 366 366
Lines 57967 57967
Branches 57967 57967
=====================================
+ Hits 42031 42034 +3
+ Misses 13836 13833 -3
Partials 2100 2100 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahasna
pushed a commit
that referenced
this pull request
Sep 19, 2023
dandanlen
added a commit
that referenced
this pull request
Sep 21, 2023
dandanlen
added a commit
that referenced
this pull request
Sep 28, 2023
dandanlen
added a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discord.com/channels/775961728608895008/776634066677923890/1153674788930342922