add support for hex encoded amounts on limit order and range order methods in LP API #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-912 Allow large hex numbers for Limit Order LP-API requests
The current LP-API methods for limit orders only support u64 representation of numbers, which is not enough for large FLIP amounts. The API should support the "NumberOrHex" mechanism used elsewhere in the API |
Codecov Report
@@ Coverage Diff @@
## main #4120 +/- ##
======================================
Coverage 71% 72%
======================================
Files 377 378 +1
Lines 60078 60637 +559
Branches 60078 60637 +559
======================================
+ Hits 42810 43490 +680
+ Misses 15022 14879 -143
- Partials 2246 2268 +22 see 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlastairHolmes
approved these changes
Oct 16, 2023
AlastairHolmes
changed the title
martin-chainflip
deleted the
feat/lp-api-limit-orders-accept-hex-amount
branch
syan095
added a commit
that referenced
this pull request
Oct 17, 2023
* origin/main: chore: get gas parameters from statechain event (#4125) Feat: ingress-egress tracking for DOT (#4121) add support for hex encoded amounts on limit order and range order methods in LP API (#4120) feat: bouncer command for submitting runtime upgrades (#4122) Feat: ensure correct process termination in ingress/egress tracker (#4101) feat(custom-rpc): add flip balance to account info (#4119) chore: storage migration delete NextCompatibilityVersion (#4115) chore: delete unneeded function (#4116) # Conflicts: # state-chain/runtime/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-912
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The current LP-API methods for limit orders only support u64 representation of numbers, which is not enough for large FLIP amounts. The API should support the "NumberOrHex" mechanism used elsewhere in the API