Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-rpc): add flip balance to account info #4119

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

acdibble
Copy link
Contributor

Pull Request

Closes: WEB-478

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Just the flip balance this time

@acdibble acdibble requested a review from a team as a code owner October 13, 2023 14:29
@acdibble acdibble requested review from niklasnatter and zoheb391 and removed request for a team October 13, 2023 14:29
@linear
Copy link

linear bot commented Oct 13, 2023

WEB-478 LP info custom RPC

Currently, we have an account info custom RPC. However, this RPC is focused entirely on accounts with the validator role.

We need to add a new custom RPC that takes an account ID and returns:

  • balances of assets
  • refund addresses
  • total collected fees (or maybe this will need to be performed by the processor)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #4119 (472b8bf) into main (99c3e0a) will increase coverage by 72%.
The diff coverage is 61%.

@@           Coverage Diff           @@
##           main   #4119      +/-   ##
=======================================
+ Coverage      0     72%     +72%     
=======================================
  Files         0     378     +378     
  Lines         0   60637   +60637     
  Branches      0   60637   +60637     
=======================================
+ Hits          0   43494   +43494     
- Misses        0   14878   +14878     
- Partials      0    2265    +2265     
Files Coverage Δ
state-chain/runtime/src/runtime_apis.rs 84% <100%> (ø)
state-chain/custom-rpc/src/lib.rs 23% <79%> (ø)
state-chain/runtime/src/lib.rs 35% <12%> (ø)

... and 375 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen merged commit 4e73511 into main Oct 13, 2023
44 checks passed
@dandanlen dandanlen deleted the feature/web-478-2 branch October 13, 2023 18:01
syan095 added a commit that referenced this pull request Oct 17, 2023
* origin/main:
  chore: get gas parameters from statechain event (#4125)
  Feat: ingress-egress tracking for DOT (#4121)
  add support for hex encoded amounts on limit order and range order methods in LP API (#4120)
  feat: bouncer command for submitting runtime upgrades (#4122)
  Feat: ensure correct process termination in ingress/egress tracker (#4101)
  feat(custom-rpc): add flip balance to account info (#4119)
  chore: storage migration delete NextCompatibilityVersion (#4115)
  chore: delete unneeded function (#4116)

# Conflicts:
#	state-chain/runtime/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants