chore: get gas parameters from statechain event #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4125 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 378 378
Lines 60637 60637
Branches 60637 60637
=====================================
+ Hits 43491 43492 +1
+ Misses 14880 14878 -2
- Partials 2266 2267 +1 see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
martin-chainflip
approved these changes
Oct 17, 2023
syan095
added a commit
that referenced
this pull request
Oct 17, 2023
* origin/main: chore: get gas parameters from statechain event (#4125) Feat: ingress-egress tracking for DOT (#4121) add support for hex encoded amounts on limit order and range order methods in LP API (#4120) feat: bouncer command for submitting runtime upgrades (#4122) Feat: ensure correct process termination in ingress/egress tracker (#4101) feat(custom-rpc): add flip balance to account info (#4119) chore: storage migration delete NextCompatibilityVersion (#4115) chore: delete unneeded function (#4116) # Conflicts: # state-chain/runtime/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Get the
maxFeePerGasand thegasLimitfrom theTransactionBroadcastRequestevent instead of relying on theChainStateUpdatedevent, which might be different that the transaction values when there is gas price fluctuations.