chore(ci): bump golangci-lint version and meet new requirements (#44)

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Author: migmartri

.github/workflows/lint.yml

@@ -31,12 +31,15 @@ jobs:
       - name: Lint main module
         uses: golangci/golangci-lint-action@v3
         if: ${{ matrix.app == 'main-module' }}
+        with:
+          version: v1.52
 
       - name: Lint ${{ matrix.app }}
         uses: golangci/golangci-lint-action@v3
         if: ${{ matrix.app != 'main-module' }}
         with:
           working-directory: app/${{ matrix.app }}
+          version: v1.52
 
   lint-protos:
     runs-on: ubuntu-latest

app/artifact-cas/internal/service/status.go

@@ -30,10 +30,10 @@ func NewStatusService(version string) *StatusService {
 	return &StatusService{version: version}
 }
 
-func (s *StatusService) Statusz(ctx context.Context, req *pb.StatuszRequest) (*pb.StatuszResponse, error) {
+func (s *StatusService) Statusz(_ context.Context, _ *pb.StatuszRequest) (*pb.StatuszResponse, error) {
 	return &pb.StatuszResponse{}, nil
 }
 
-func (s *StatusService) Infoz(ctx context.Context, req *pb.InfozRequest) (*pb.InfozResponse, error) {
+func (s *StatusService) Infoz(_ context.Context, _ *pb.InfozRequest) (*pb.InfozResponse, error) {
 	return &pb.InfozResponse{Version: s.version}, nil
 }

app/cli/cmd/output.go

@@ -18,6 +18,7 @@ package cmd
 import (
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io"
 	"os"
 
@@ -65,7 +66,7 @@ func encodeJSONToWriter(v interface{}, w io.Writer) error {
 	encoder := json.NewEncoder(w)
 	encoder.SetIndent("", "   ")
 	if err := encoder.Encode(v); err != nil {
-		return err
+		return fmt.Errorf("failed to encode output: %w", err)
 	}
 
 	return nil

app/cli/cmd/root.go

@@ -85,7 +85,7 @@ func NewRootCmd(l zerolog.Logger) *cobra.Command {
 			return nil
 		},
 		PersistentPostRunE: func(cmd *cobra.Command, args []string) error {
-			return cleanup(logger, actionOpts.CPConnection)
+			return cleanup(actionOpts.CPConnection)
 		},
 	}
 
@@ -167,7 +167,7 @@ func newActionOpts(logger zerolog.Logger, conn *grpc.ClientConn) *action.Actions
 	return &action.ActionsOpts{CPConnection: conn, Logger: logger}
 }
 
-func cleanup(logger zerolog.Logger, conn *grpc.ClientConn) error {
+func cleanup(conn *grpc.ClientConn) error {
 	if conn != nil {
 		if err := conn.Close(); err != nil {
 			return err

app/cli/cmd/workflow_integration_list.go

@@ -54,17 +54,17 @@ func integrationAttachmentListTableOutput(attachments []*action.IntegrationAttac
 	t.AppendHeader(table.Row{"ID", "Kind", "Config", "Attached At", "Workflow"})
 	for _, i := range attachments {
 		wf := i.Workflow
-		int := i.Integration
+		integration := i.Integration
 
-		maps.Copy(i.Config, int.Config)
+		maps.Copy(i.Config, integration.Config)
 		var options []string
 		for k, v := range i.Config {
 			if v == "" {
 				continue
 			}
 			options = append(options, fmt.Sprintf("%s: %v", k, v))
 		}
-		t.AppendRow(table.Row{i.ID, int.Kind, strings.Join(options, "\n"), i.CreatedAt.Format(time.RFC822), wf.NamespacedName()})
+		t.AppendRow(table.Row{i.ID, integration.Kind, strings.Join(options, "\n"), i.CreatedAt.Format(time.RFC822), wf.NamespacedName()})
 		t.AppendSeparator()
 	}
 

app/cli/cmd/workflow_robotaccount_create.go

@@ -32,11 +32,7 @@ func newWorkflowRobotAccountCreateCmd() *cobra.Command {
 				return err
 			}
 
-			if err := encodeOutput([]*action.WorkflowRobotAccountItem{res}, robotAccountListTableOutput); err != nil {
-				return err
-			}
-
-			return nil
+			return encodeOutput([]*action.WorkflowRobotAccountItem{res}, robotAccountListTableOutput)
 		},
 	}
 

app/cli/internal/action/artifact_download.go

@@ -81,7 +81,7 @@ func (a *ArtifactDownload) Run(downloadPath, digest string) error {
 	a.Logger.Info().Str("name", info.Filename).Str("to", downloadPath).Msg("downloading file")
 
 	// render progress bar
-	go renderOperationStatus(ctx, client.ProgressStatus, a.Logger, info.Size)
+	go renderOperationStatus(ctx, client.ProgressStatus, info.Size)
 	defer close(client.ProgressStatus)
 
 	err = client.Download(ctx, w, h.Hex)
@@ -103,7 +103,7 @@ func (a *ArtifactDownload) Run(downloadPath, digest string) error {
 	return nil
 }
 
-func renderOperationStatus(ctx context.Context, progressChan casclient.ProgressStatusChan, output io.Writer, totalSize int64) {
+func renderOperationStatus(ctx context.Context, progressChan casclient.ProgressStatusChan, totalSize int64) {
 	pw := progress.NewWriter()
 	pw.Style().Visibility.ETA = true
 	pw.Style().Visibility.Speed = true

app/cli/internal/action/artifact_upload.go

@@ -60,7 +60,7 @@ func (a *ArtifactUpload) Run(filePath string) (*CASArtifact, error) {
 	}
 
 	// render progress bar
-	go renderOperationStatus(context.Background(), client.ProgressStatus, a.Logger, info.Size())
+	go renderOperationStatus(context.Background(), client.ProgressStatus, info.Size())
 	defer close(client.ProgressStatus)
 
 	res, err := client.Upload(context.Background(), filePath)

app/controlplane/api/controlplane/v1/integrations_config.go

@@ -34,11 +34,9 @@ func (x *IntegrationConfig) Scan(src any) error {
 		return nil
 	}
 	if b, ok := src.([]byte); ok {
-		if err := proto.Unmarshal(b, x); err != nil {
-			return err
-		}
-		return nil
+		return proto.Unmarshal(b, x)
 	}
+
 	return fmt.Errorf("unexpected type %T", src)
 }
 
@@ -52,10 +50,8 @@ func (x *IntegrationAttachmentConfig) Scan(src any) error {
 		return nil
 	}
 	if b, ok := src.([]byte); ok {
-		if err := proto.Unmarshal(b, x); err != nil {
-			return err
-		}
-		return nil
+		return proto.Unmarshal(b, x)
 	}
+
 	return fmt.Errorf("unexpected type %T", src)
 }

app/controlplane/cmd/main.go

@@ -133,7 +133,7 @@ type app struct {
 	runsExpirer *biz.WorkflowRunExpirerUseCase
 }
 
-func filterSensitiveArgs(level log.Level, keyvals ...interface{}) bool {
+func filterSensitiveArgs(_ log.Level, keyvals ...interface{}) bool {
 	for i := 0; i < len(keyvals); i++ {
 		if keyvals[i] == "operation" {
 			switch keyvals[i+1] {