feat: Azure Devops Pipeline support - use AZURE_PIPELINE instead of AZURE_DEVOPS_PIPELINE

Signed-off-by: Daniel Liszka <daniel@chainloop.dev>

Author: danlishka

app/cli/internal/action/workflow_run_list.go

@@ -115,8 +115,8 @@ func humanizedRunnerType(in v1.CraftingSchema_Runner_RunnerType) string {
 		return "GitHub"
 	case *v1.CraftingSchema_Runner_GITLAB_PIPELINE.Enum():
 		return "GitLab"
-	case *v1.CraftingSchema_Runner_AZURE_DEVOPS_PIPELINE.Enum():
-		return "Azure DevOps Pipeline"
+	case *v1.CraftingSchema_Runner_AZURE_PIPELINE.Enum():
+		return "Azure Pipeline"
 	default:
 		return "Unspecified"
 	}

app/controlplane/api/gen/frontend/workflowcontract/v1/crafting_schema.ts

@@ -37,7 +37,7 @@ message CraftingSchema {
             RUNNER_TYPE_UNSPECIFIED = 0;
             GITHUB_ACTION = 1;
             GITLAB_PIPELINE = 2;
-            AZURE_DEVOPS_PIPELINE = 3;
+            AZURE_PIPELINE = 3;
         } 
     }
 

app/controlplane/api/workflowcontract/v1/crafting_schema.pb.go

@@ -42,8 +42,8 @@ func NewRunner(t schemaapi.CraftingSchema_Runner_RunnerType) supportedRunner {
 		return &runners.GitHubAction{}
 	case schemaapi.CraftingSchema_Runner_GITLAB_PIPELINE:
 		return &runners.GitlabPipeline{}
-	case schemaapi.CraftingSchema_Runner_AZURE_DEVOPS_PIPELINE:
-		return &runners.AzureDevopsPipeline{}
+	case schemaapi.CraftingSchema_Runner_AZURE_PIPELINE:
+		return &runners.AzurePipeline{}
 	default:
 		return &runners.Generic{}
 	}

app/controlplane/api/workflowcontract/v1/crafting_schema.proto

@@ -21,16 +21,16 @@ import (
 	"path"
 )
 
-type AzureDevopsPipeline struct{}
+type AzurePipeline struct{}
 
-const AzureDevopsPipelineID = "azure-devops-pipeline"
+const AzurePipelineID = "azure-pipeline"
 
-func NewAzureDevopsPipeline() *AzureDevopsPipeline {
-	return &AzureDevopsPipeline{}
+func NewAzurePipeline() *AzurePipeline {
+	return &AzurePipeline{}
 }
 
-// Figure out if we are in a AzureDevops Pipeline job or not
-func (r *AzureDevopsPipeline) CheckEnv() bool {
+// Figure out if we are in a Azure Pipeline job or not
+func (r *AzurePipeline) CheckEnv() bool {
 	for _, varName := range []string{"TF_BUILD", "BUILD_BUILDURI"} {
 		if os.Getenv(varName) == "" {
 			return false
@@ -40,7 +40,7 @@ func (r *AzureDevopsPipeline) CheckEnv() bool {
 	return true
 }
 
-func (r *AzureDevopsPipeline) ListEnvVars() []string {
+func (r *AzurePipeline) ListEnvVars() []string {
 	return []string{
 		"BUILD_REQUESTEDFOREMAIL",
 		"BUILD_REQUESTEDFOR",
@@ -55,15 +55,15 @@ func (r *AzureDevopsPipeline) ListEnvVars() []string {
 	}
 }
 
-func (r *AzureDevopsPipeline) ResolveEnvVars() map[string]string {
+func (r *AzurePipeline) ResolveEnvVars() map[string]string {
 	return resolveEnvVars(r.ListEnvVars())
 }
 
-func (r *AzureDevopsPipeline) String() string {
-	return AzureDevopsPipelineID
+func (r *AzurePipeline) String() string {
+	return AzurePipelineID
 }
 
-func (r *AzureDevopsPipeline) RunURI() (url string) {
+func (r *AzurePipeline) RunURI() (url string) {
 	teamFoundationServerURI := os.Getenv("SYSTEM_TEAMFOUNDATIONSERVERURI")
 	definitionName := os.Getenv("SYSTEM_DEFINITIONNAME")
 	buildID := os.Getenv("BUILD_BUILDID")

internal/attestation/crafter/runner.go

@@ -23,12 +23,12 @@ import (
 	"github.com/stretchr/testify/suite"
 )
 
-type azureDevopsPipelineSuite struct {
+type azurePipelineSuite struct {
 	suite.Suite
-	runner *AzureDevopsPipeline
+	runner *AzurePipeline
 }
 
-func (s *azureDevopsPipelineSuite) TestCheckEnv() {
+func (s *azurePipelineSuite) TestCheckEnv() {
 	testCases := []struct {
 		name string
 		env  map[string]string
@@ -77,7 +77,7 @@ func (s *azureDevopsPipelineSuite) TestCheckEnv() {
 	}
 }
 
-func (s *azureDevopsPipelineSuite) TestListEnvVars() {
+func (s *azurePipelineSuite) TestListEnvVars() {
 	assert.Equal(s.T(), []string{
 		"BUILD_REQUESTEDFOREMAIL",
 		"BUILD_REQUESTEDFOR",
@@ -92,7 +92,7 @@ func (s *azureDevopsPipelineSuite) TestListEnvVars() {
 	}, s.runner.ListEnvVars())
 }
 
-func (s *azureDevopsPipelineSuite) TestResolveEnvVars() {
+func (s *azurePipelineSuite) TestResolveEnvVars() {
 	s.Equal(map[string]string{
 		"AGENT_VERSION":           "3.220.5",
 		"BUILD_BUILDID":           "6",
@@ -107,17 +107,17 @@ func (s *azureDevopsPipelineSuite) TestResolveEnvVars() {
 	}, s.runner.ResolveEnvVars())
 }
 
-func (s *azureDevopsPipelineSuite) TestRunURI() {
+func (s *azurePipelineSuite) TestRunURI() {
 	s.Equal("https://dev.azure.com/chainloop-test/chainloop-tests/_build/results?buildId=6&j=12f1170f-0000-0000-20dd-22fc7dff55f9&view=logs", s.runner.RunURI())
 }
 
-func (s *azureDevopsPipelineSuite) TestRunnerName() {
-	s.Equal("azure-devops-pipeline", s.runner.String())
+func (s *azurePipelineSuite) TestRunnerName() {
+	s.Equal("azure-pipeline", s.runner.String())
 }
 
 // Run before each test
-func (s *azureDevopsPipelineSuite) SetupTest() {
-	s.runner = NewAzureDevopsPipeline()
+func (s *azurePipelineSuite) SetupTest() {
+	s.runner = NewAzurePipeline()
 	t := s.T()
 	t.Setenv("TF_BUILD", "True")
 	t.Setenv("BUILD_REPOSITORY_ID", "5e5bf8eb-0000-0000-801b-0a5bc4b4011a")
@@ -147,6 +147,6 @@ func (s *azureDevopsPipelineSuite) SetupTest() {
 }
 
 // Run the tests
-func TestAzureDevopsPipelineRunner(t *testing.T) {
-	suite.Run(t, new(azureDevopsPipelineSuite))
+func TestAzurePipelineRunner(t *testing.T) {
+	suite.Run(t, new(azurePipelineSuite))
 }