Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controlplane): store and show the digest in CAS of the attestation #329

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

migmartri
Copy link
Member

Soon, we'll be able to share download URLs for attestations #263. This requires finding the digest to share in the first place.

This patch does store the digest, uses to store the attestation in the CAS, then it exposes it the API and CLI, so it can be easily shared.

image

The reason to store it at save time instead of calculating it is to guarantee that the format is the same one at the time of saving it in the CAS, it also saves computation time in each listing

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit 4dfcd62 into chainloop-dev:main Sep 5, 2023
10 checks passed
@migmartri migmartri deleted the show-attestation-digest branch September 5, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants