Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm CacheMap usage - fix HMR in some setups #2612

Merged
merged 2 commits into from
May 21, 2024

Conversation

astahmer
Copy link
Collaborator

Closes #2608

📝 Description

Fix a cache issue that leads to HMR growing slower in some cases

💣 Is this a breaking change (Yes/No):

no

📝 Additional Information

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview May 20, 2024 8:00pm
panda-playground ✅ Ready (Inspect) Visit Preview May 20, 2024 8:00pm
panda-studio ✅ Ready (Inspect) Visit Preview May 20, 2024 8:00pm

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: 701e777

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@pandacss/shared Patch
@pandacss/core Patch
@pandacss/node Patch
@pandacss/dev Patch
@pandacss/config Patch
@pandacss/extractor Patch
@pandacss/generator Patch
@pandacss/parser Patch
@pandacss/studio Patch
@pandacss/token-dictionary Patch
@pandacss/astro-plugin-studio Patch
@pandacss/postcss Patch
@pandacss/types Patch
@pandacss/is-valid-prop Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-base Patch
@pandacss/preset-open-props Patch
@pandacss/preset-panda Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@astahmer astahmer changed the title chore: rm CacheMap in Utility - fix HMR in some setups chore: rm CacheMap usage - fix HMR in some setups May 20, 2024
@segunadebayo segunadebayo merged commit 1f636eb into main May 21, 2024
7 checks passed
@segunadebayo segunadebayo deleted the fix/hmr-growing-slower branch May 21, 2024 12:27
@Pinpickle
Copy link

@segunadebayo this PR broke my Panda setup for some reason. I mentioned it on Discord but nobody got back to me.

It's really hard to make a reproduction. Here's what I've noticed when using Vite with the postcss plugin. When I first load my app, the CSS is loaded fine. Then, when I save any file in my project, all of the CSS except for the styles in that file goes away. Then, it incrementally adds styles as I go and save other files.

Reverting this change (turning the Map constructors back into CacheMap constructors) fixes the issue somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants