-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rm CacheMap usage - fix HMR in some setups #2612
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 701e777 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
822e1bf
to
1cdcb63
Compare
@segunadebayo this PR broke my Panda setup for some reason. I mentioned it on Discord but nobody got back to me. It's really hard to make a reproduction. Here's what I've noticed when using Vite with the postcss plugin. When I first load my app, the CSS is loaded fine. Then, when I save any file in my project, all of the CSS except for the styles in that file goes away. Then, it incrementally adds styles as I go and save other files. Reverting this change (turning the Map constructors back into CacheMap constructors) fixes the issue somehow. |
Closes #2608
📝 Description
Fix a cache issue that leads to HMR growing slower in some cases
💣 Is this a breaking change (Yes/No):
no
📝 Additional Information