Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combobox, select, menu, tabs #1431

Merged
merged 23 commits into from
Apr 19, 2024
Merged

refactor: combobox, select, menu, tabs #1431

merged 23 commits into from
Apr 19, 2024

Conversation

segunadebayo
Copy link
Member

@segunadebayo segunadebayo commented Apr 15, 2024

Closes #1276

📝 Description

  • Improve composition between menu + combobox
  • Add open property to combobox to programmatically control the combobox
  • Fix multiple + selectionBehavior=clear issue
  • Remove selectOnBlur, which can lead to unexpected side effects

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

Yes

📝 Additional Information

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 58b46a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 72 packages
Name Type
@zag-js/combobox Minor
@zag-js/tags-input Minor
@zag-js/dialog Minor
@zag-js/menu Minor
@zag-js/select Minor
@zag-js/tabs Minor
@zag-js/anatomy-icons Minor
@zag-js/anatomy Minor
@zag-js/core Minor
@zag-js/docs Minor
@zag-js/preact Minor
@zag-js/react Minor
@zag-js/solid Minor
@zag-js/svelte Minor
@zag-js/vue Minor
@zag-js/accordion Minor
@zag-js/avatar Minor
@zag-js/carousel Minor
@zag-js/checkbox Minor
@zag-js/clipboard Minor
@zag-js/collapsible Minor
@zag-js/color-picker Minor
@zag-js/date-picker Minor
@zag-js/editable Minor
@zag-js/file-upload Minor
@zag-js/floating-panel Minor
@zag-js/hover-card Minor
@zag-js/number-input Minor
@zag-js/pagination Minor
@zag-js/pin-input Minor
@zag-js/popover Minor
@zag-js/presence Minor
@zag-js/progress Minor
@zag-js/radio-group Minor
@zag-js/rating-group Minor
@zag-js/signature-pad Minor
@zag-js/slider Minor
@zag-js/splitter Minor
@zag-js/switch Minor
@zag-js/toast Minor
@zag-js/toggle-group Minor
@zag-js/tooltip Minor
@zag-js/tour Minor
@zag-js/tree-view Minor
@zag-js/store Minor
@zag-js/types Minor
@zag-js/aria-hidden Minor
@zag-js/auto-resize Minor
@zag-js/collection Minor
@zag-js/color-utils Minor
@zag-js/utils Minor
@zag-js/date-utils Minor
@zag-js/dismissable Minor
@zag-js/dom-event Minor
@zag-js/dom-query Minor
@zag-js/element-rect Minor
@zag-js/element-size Minor
@zag-js/file-utils Minor
@zag-js/focus-scope Minor
@zag-js/focus-visible Minor
@zag-js/form-utils Minor
@zag-js/i18n-utils Minor
@zag-js/interact-outside Minor
@zag-js/live-region Minor
@zag-js/number-utils Minor
@zag-js/numeric-range Minor
@zag-js/popper Minor
@zag-js/rect-utils Minor
@zag-js/remove-scroll Minor
@zag-js/tabbable Minor
@zag-js/text-selection Minor
@zag-js/visually-hidden Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:22pm
zag-solid ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:22pm
zag-svelte ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:22pm
zag-vue ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:22pm
zag-website ✅ Ready (Inspect) Visit Preview Apr 19, 2024 10:22pm

Copy link
Contributor

Visualize the logic of the machines here 🎊

@segunadebayo segunadebayo changed the title refactor: improve combobox + tags-input composition refactor: combobox, select, menu Apr 17, 2024
@segunadebayo segunadebayo merged commit 80b97a9 into main Apr 19, 2024
20 checks passed
@segunadebayo segunadebayo deleted the refactor/combobox branch April 19, 2024 23:17
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
colinlienard pushed a commit to colinlienard/zag that referenced this pull request Jun 18, 2024
* chore: wip

* fix: typecheck

* fix: website

* refactor: ux refactor of combobox and related components

* fix: self target

* refactor: menu

* chore: update menu

* chore: update

* docs: add combobox change log

* chore: update

* docs: add typedocs

* fix: website search

* refactor: combobox

* fix: e2e

* refactor: loop -> loopFocus

* fix: e2e

* fix: typecheck and playground

* fix: typecheck

* fix: typecheck

* docs: add changeset

* chore: export and update changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox with multiple=true and selectionBehavior=clear doesn't work
1 participant