-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: combobox, select, menu, tabs #1431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 58b46a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Visualize the logic of the machines here 🎊 |
segunadebayo
changed the title
refactor: improve combobox + tags-input composition
refactor: combobox, select, menu
Apr 17, 2024
Merged
colinlienard
pushed a commit
to colinlienard/zag
that referenced
this pull request
Jun 18, 2024
* chore: wip * fix: typecheck * fix: website * refactor: ux refactor of combobox and related components * fix: self target * refactor: menu * chore: update menu * chore: update * docs: add combobox change log * chore: update * docs: add typedocs * fix: website search * refactor: combobox * fix: e2e * refactor: loop -> loopFocus * fix: e2e * fix: typecheck and playground * fix: typecheck * fix: typecheck * docs: add changeset * chore: export and update changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1276
📝 Description
open
property to combobox to programmatically control the comboboxselectOnBlur
, which can lead to unexpected side effects⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
Yes
📝 Additional Information