Fix failing tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Actions CI has been failing for a while because the output is not rendering colored. This is because `test.js` was setting `FORCE_COLOR=1` but this happens after the `import` of `chalk` and thus also after the import within chalk of [`supports-color`](https://www.npmjs.com/package/supports-color) JS likes imports to be at the top of files before any other logic, so it's not really possible to set `FORCE_COLOR` any earlier within `test.js`. But it *is* possible to set it in `package.json` while invoking `ava`... Fixes: chalkGH-27
msabramo
force-pushed
the
fix-failing-tests-FORCE_COLOR
branch
from
28701e8
to
6458c59
Compare
These versions of Node no longer pass tests, I think because [yargs-parser only supports node >= 10]( https://github.com/yargs/yargs-parser/blob/main/package.json#L79-L81): ```js "engines": { "node": ">=10" }, ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Actions CI has been failing for a while because the output is not rendering colored. This is because
test.jswas settingFORCE_COLOR=1but this happens after theimportofchalkand thus also after the import within chalk ofsupports-colorJS likes imports to be at the top of files before any other logic, so it's not really possible to set
FORCE_COLORany earlier withintest.js. But it is possible to set it inpackage.jsonwhile invokingava...Fixes: GH-27
This PR also removes node versions 8 and 6 from the list of versions to test, because
yargs-parseronly supports node >= 10 now. Note that we go forward with converting chalk-cli to ESM (see #26), then we will require node >= 12.🎉