Allow cli with file name argument to be used from scripts #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is currently failing because the file name argument is only used if stdin is a TTY, which is not the case when being invoked from a script.
When invoked from a parent shell script the file name was previously ignored because stdin was closed or otherwise not detected as a TTY.
|
You can use |
sindresorhus
added a commit
that referenced
this pull request
Jan 16, 2015
Allow cli with file name argument to be used from scripts
|
Or All assuming that the parent process's stdin is a TTY and not deeply nested in some headless environment, of course ;-) Thanks for the merge & release :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoked via
exec()/system()/whatever from a parent script, stdin is generally not a TTY. In the current version of strip-ansi, this prevents any arguments from being used as the filename even if provided.The first commit adds this scenario as a test case (initially failing). The second commit allows the filename argument, if provided, to be used when scripting.
I found this when I tried to use strip-ansi in my CI pipeline to strip colourized diffs from my TAP result files but was perplexed by the result being an empty file. I am using the
cat file | strip-ansi > stripped.txtform as a workaround for now.