Minor: Format code + fix psalm

Author: AngelFQC

src/CoreBundle/Component/Utils/ChamiloApi.php

@@ -6,6 +6,7 @@
 
 namespace Chamilo\CoreBundle\Component\Utils;
 
+use Chamilo\CoreBundle\Framework\Container;
 use ChamiloSession as Session;
 use Database;
 use DateInterval;
@@ -156,7 +157,7 @@ public static function getPlatformLogo(
     ): string {
         $logoPath = Container::getThemeHelper()->getThemeAssetUrl('images/header-logo.svg');
 
-        if (empty($logo)) {
+        if (empty($logoPath)) {
             $logoPath = Container::getThemeHelper()->getThemeAssetUrl('images/header-logo.png');
         }
 

src/CoreBundle/Form/PermissionType.php

@@ -11,6 +11,9 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @template-extends AbstractType<string>
+ */
 class PermissionType extends AbstractType
 {
     public function buildForm(FormBuilderInterface $builder, array $options): void

src/CoreBundle/Migrations/Schema/V200/Version20230215072918.php

@@ -50,7 +50,7 @@ public function up(Schema $schema): void
 
                 if (!empty($items)) {
                     foreach ($items as $item) {
-                        if (!($item['to_user_id'] === NULL || $item['to_user_id'] === 0)) {
+                        if (!(null === $item['to_user_id'] || 0 === $item['to_user_id'])) {
                             $sessionId = $item['session_id'] ?? 0;
                             $userId = $item['to_user_id'] ?? 0;
                             $session = $sessionRepo->find($sessionId);

src/CoreBundle/Migrations/Schema/V200/Version20240713125400.php

@@ -25,17 +25,16 @@ public function up(Schema $schema): void
         foreach ($users as $user) {
             $roles = unserialize($user['roles']);
 
-            if ($roles !== false) {
+            if (false !== $roles) {
                 $updatedRoles = array_map(function ($role) {
-                    return $role === 'ROLE_RRHH' ? 'ROLE_HR' : $role;
+                    return 'ROLE_RRHH' === $role ? 'ROLE_HR' : $role;
                 }, $roles);
 
                 $newRolesSerialized = serialize($updatedRoles);
                 $conn->executeUpdate(
                     'UPDATE user SET roles = ? WHERE id = ?',
                     [$newRolesSerialized, $user['id']]
                 );
-
             }
         }
     }
@@ -49,9 +48,9 @@ public function down(Schema $schema): void
         foreach ($users as $user) {
             $roles = unserialize($user['roles']);
 
-            if ($roles !== false) {
+            if (false !== $roles) {
                 $updatedRoles = array_map(function ($role) {
-                    return $role === 'ROLE_HR' ? 'ROLE_RRHH' : $role;
+                    return 'ROLE_HR' === $role ? 'ROLE_RRHH' : $role;
                 }, $roles);
 
                 $newRolesSerialized = serialize($updatedRoles);

src/CoreBundle/Migrations/Schema/V200/Version20240715183456.php

@@ -31,7 +31,5 @@ public function up(Schema $schema): void
         $this->addSql("DELETE FROM extra_field WHERE variable = 'special_course' AND item_type = $extraFieldType");
     }
 
-    public function down(Schema $schema): void
-    {
-    }
+    public function down(Schema $schema): void {}
 }