Upgrade #5329
Upgrade #5329
Conversation
AngelFQC
force-pushed
the
upgrade
branch
2 times, most recently
from
c177567
to
5c4ab05
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5329 +/- ##
============================================
+ Coverage 39.31% 40.03% +0.72%
- Complexity 10282 10313 +31
============================================
Files 814 817 +3
Lines 43555 43373 -182
============================================
+ Hits 17125 17366 +241
+ Misses 26430 26007 -423 ☔ View full report in Codecov by Sentry. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| /** | ||
| * @Route("/{category}/{path}", methods={"GET"}, requirements={"path"=".+"}, name="chamilo_core_asset_showfile") | ||
| */ | ||
| #[Route(path: '/{category}/{path}', methods: ['GET'], requirements: ['path' => '.+'], name: 'chamilo_core_asset_showfile')] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| * @Route("/resources/chat/", name="chat_home", options={"expose"=true}) | ||
| */ | ||
| public function indexAction(Request $request): Response | ||
| #[Route(path: '/resources/chat/', name: 'chat_home', options: ['expose' => true])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| */ | ||
| public function indexAction(Request $request): Response | ||
| #[Route(path: '/resources/chat/', name: 'chat_home', options: ['expose' => true])] | ||
| public function index(): Response |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| * @Route("/resources/chat/conversations/", name="chat_ajax", options={"expose"=true}) | ||
| */ | ||
| public function ajaxAction(Request $request, ResourceNodeRepository $repo): Response | ||
| #[Route(path: '/resources/chat/conversations/', name: 'chat_ajax', options: ['expose' => true])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| */ | ||
| public function ajaxAction(Request $request, ResourceNodeRepository $repo): Response | ||
| #[Route(path: '/resources/chat/conversations/', name: 'chat_ajax', options: ['expose' => true])] | ||
| public function ajax(Request $request, ResourceNodeRepository $repo): Response |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| /** | ||
| * @Route("/contact", name="contact") | ||
| */ | ||
| #[Route(path: '/contact', name: 'contact')] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| */ | ||
| public function editorTemplatesAction(TranslatorInterface $translator, RouterInterface $router): Response | ||
| #[Route(path: '/templates', methods: ['GET'], name: 'editor_templates')] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| */ | ||
| public function editorTemplatesAction(TranslatorInterface $translator, RouterInterface $router): Response | ||
| #[Route(path: '/templates', methods: ['GET'], name: 'editor_templates')] | ||
| public function editorTemplates(TranslatorInterface $translator, RouterInterface $router): Response |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| class ExceptionController extends AbstractController | |||
| { | |||
| public function showAction(Exception $exception): Response | |||
| public function show(Exception $exception): Response | |||
| * @Route("/error") | ||
| */ | ||
| public function errorAction(Request $request): Response | ||
| #[Route(path: '/error')] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| */ | ||
| public function errorAction(Request $request): Response | ||
| #[Route(path: '/error')] | ||
| public function error(Request $request): Response |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -43,7 +43,7 @@ public function list(): JsonResponse | |||
| } | |||
|
|
|||
| #[Route('/upload', name: 'file_manager_upload', methods: ['POST'])] | |||
| public function upload(Request $request): JsonResponse | |||
| public function upload(): JsonResponse | |||
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -81,21 +81,21 @@ | |||
| } | |||
|
|
|||
| #[Route('/create-folder', name: 'file_manager_create_folder', methods: ['POST'])] | |||
| public function createFolder(Request $request): JsonResponse | |||
| public function createFolder(): JsonResponse | |||
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| { | ||
| // Implement logic to create new folders | ||
| return $this->json(['message' => 'Folder created successfully']); | ||
| } | ||
|
|
||
| #[Route('/rename', name: 'file_manager_rename', methods: ['POST'])] | ||
| public function rename(Request $request): JsonResponse | ||
| public function rename(): JsonResponse |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| { | ||
| // Implement logic to rename files/folders | ||
| return $this->json(['message' => 'File/folder renamed successfully']); | ||
| } | ||
|
|
||
| #[Route('/delete', name: 'file_manager_delete', methods: ['DELETE'])] | ||
| public function delete(Request $request): JsonResponse | ||
| public function delete(): JsonResponse |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| * @Route("/social", name="social", options={"expose"=true}, name="chamilo_core_socialnetwork") | ||
| * @Route("/admin", name="admin", options={"expose"=true}) | ||
| */ | ||
| #[Route('/', name: 'index', options: ['expose' => true], methods: ['GET', 'POST'])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| #[Route('/sessions', name: 'sessions')] | ||
| #[Route('/sessions/{extra}', name: 'sessions_options')] | ||
| #[Route('/admin/configuration/colors', name: 'configuration_colors')] | ||
| public function indexAction(): Response | ||
| #[Route('/home', name: 'home', options: ['expose' => true], methods: ['GET', 'POST'])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| #[Route('/sessions', name: 'sessions')] | ||
| #[Route('/sessions/{extra}', name: 'sessions_options')] | ||
| #[Route('/admin/configuration/colors', name: 'configuration_colors')] | ||
| public function indexAction(): Response | ||
| #[Route('/home', name: 'home', options: ['expose' => true], methods: ['GET', 'POST'])] | ||
| #[Route('/login', name: 'login', options: ['expose' => true], methods: ['GET', 'POST'])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| public function indexAction(): Response | ||
| #[Route('/home', name: 'home', options: ['expose' => true], methods: ['GET', 'POST'])] | ||
| #[Route('/login', name: 'login', options: ['expose' => true], methods: ['GET', 'POST'])] | ||
| #[Route('/faq', name: 'faq', options: ['expose' => true], methods: ['GET', 'POST'])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| #[Route('/home', name: 'home', options: ['expose' => true], methods: ['GET', 'POST'])] | ||
| #[Route('/login', name: 'login', options: ['expose' => true], methods: ['GET', 'POST'])] | ||
| #[Route('/faq', name: 'faq', options: ['expose' => true], methods: ['GET', 'POST'])] | ||
| #[Route('/demo', name: 'demo', options: ['expose' => true], methods: ['GET', 'POST'])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
AngelFQC
force-pushed
the
upgrade
branch
2 times, most recently
from
6a485b1
to
04e1f54
Compare
…hamilo/settings-bundle version to 1.3.0
|
An error occurred when fetching issues. View more on Code Climate. |
No description provided.