[C2] Messages: Fix the profile image of users #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the component BaseUserAvatar to show images of users * Use pinia store to get user instead of vuex (we are currently migrating to pinia)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5392 +/- ##
============================================
- Coverage 40.77% 40.22% -0.56%
- Complexity 10214 10328 +114
============================================
Files 807 817 +10
Lines 42433 43413 +980
============================================
+ Hits 17304 17462 +158
- Misses 25129 25951 +822 ☔ View full report in Codecov by Sentry. |
|
An error occurred when fetching issues. View more on Code Climate. |
ywarnier
added a commit
that referenced
this pull request
Apr 23, 2024
ywarnier
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message screen now looks like
There is no design for this in figma file https://www.figma.com/file/xVjyMvmrZdlr8ZyKeoQ5n5/Dashboard?node-id=99-16149&t=kofcZkADJlifIV9C-0, at least I couldn't find it.
So I decide to use 40x40 pictures like figma design for course cards to show the avatar of the user. This will be the normal size. For large and xlarge I selected some arbitrary values. Xlarge is the size of your profile picture on the left.
#5389
The course component list use something similar. For consistency, change the course list layout to use the new avatar component. This view will change from this:
to this: