Message: Allow attachments #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dpoint - refs BT#21648
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -157,8 +157,14 @@ class Message | |||
| /** | |||
| * @var Collection<int, MessageAttachment> | |||
| */ | |||
| #[Groups(['message:read'])] | |||
| #[ORM\OneToMany(mappedBy: 'message', targetEntity: MessageAttachment::class, cascade: ['remove', 'persist'])] | |||
| #[Assert\Valid] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| #[ORM\OneToMany(mappedBy: 'message', targetEntity: MessageAttachment::class, cascade: ['remove', 'persist'])] | ||
| #[Assert\Valid] | ||
| #[Groups(['message:read', 'message:write'])] | ||
| #[ORM\OneToMany( |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| @@ -374,10 +380,27 @@ | |||
| return $this->attachments; | |||
| } | |||
|
|
|||
| public function addAttachment(MessageAttachment $attachment): self | |||
| public function addAttachment(MessageAttachment $attachment): static | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| @@ -374,10 +380,27 @@ | |||
| return $this->attachments; | |||
| } | |||
|
|
|||
| public function addAttachment(MessageAttachment $attachment): self | |||
| public function addAttachment(MessageAttachment $attachment): static | |||
| @@ -374,10 +380,27 @@ | |||
| return $this->attachments; | |||
| } | |||
|
|
|||
| public function addAttachment(MessageAttachment $attachment): self | |||
| public function addAttachment(MessageAttachment $attachment): static | |||
There was a problem hiding this comment.
Scope keyword "static" must be followed by a single space
|
Code Climate has analyzed commit df2d7e4 and detected 41 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs BT#21648