Internal: Improve migration process from install page #5771
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ->execute() | ||
| ->fetchOne(); | ||
|
|
||
| $progress_percentage = 0; |
There was a problem hiding this comment.
Variable "progress_percentage" is not in valid camel caps format
|
|
||
| $progress_percentage = 0; | ||
| if ($totalMigrations > 0) { | ||
| $progress_percentage = ($executedMigrations / $totalMigrations) * 100; |
There was a problem hiding this comment.
Variable "progress_percentage" is not in valid camel caps format
| $progress_percentage = ($executedMigrations / $totalMigrations) * 100; | ||
| } | ||
|
|
||
| $current_migration = $connection->createQueryBuilder() |
There was a problem hiding this comment.
Variable "current_migration" is not in valid camel caps format
| ->fetchOne(); | ||
|
|
||
| return [ | ||
| 'progress_percentage' => ceil($progress_percentage), |
There was a problem hiding this comment.
Variable "progress_percentage" is not in valid camel caps format
|
|
||
| return [ | ||
| 'progress_percentage' => ceil($progress_percentage), | ||
| 'current_migration' => $current_migration, |
There was a problem hiding this comment.
Variable "current_migration" is not in valid camel caps format
| * | ||
| * @return EntityManager The initialized EntityManager | ||
| */ | ||
| function initializeEntityManager(): EntityManager |
There was a problem hiding this comment.
Consider putting global function "initializeEntityManager" in a static class
| * | ||
| * @return bool True if the version table is valid, false otherwise | ||
| */ | ||
| function isVersionTableValid($connection): bool |
There was a problem hiding this comment.
Consider putting global function "isVersionTableValid" in a static class
| * | ||
| * @return string The last executed migration version | ||
| */ | ||
| function getLastExecutedMigration(Connection $connection): string |
There was a problem hiding this comment.
Consider putting global function "getLastExecutedMigration" in a static class
| ->orderBy('executed_at', 'DESC') | ||
| ->setMaxResults(1); | ||
| $result = $query->execute()->fetchAssociative(); | ||
| return $result['version'] ?? ''; |
There was a problem hiding this comment.
Missing blank line before return statement
| * | ||
| * @return array The result status of the migration | ||
| */ | ||
| function executeMigration(): array |
There was a problem hiding this comment.
Consider putting global function "executeMigration" in a static class
|
Code Climate has analyzed commit d722954 and detected 57 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.