Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chash files:clean_data_files deletes courses #17

Closed
ywarnier opened this issue Feb 7, 2014 · 2 comments
Closed

chash files:clean_data_files deletes courses #17

ywarnier opened this issue Feb 7, 2014 · 2 comments
Labels

Comments

@ywarnier
Copy link
Member

ywarnier commented Feb 7, 2014

In the clean_data_files action, the finder is getDataFolders(), which returns the contents of the "courses/" directory.

This is confusing (actually, the name of the command is confusing) as the comment at the beginning of the class shows "Clean the archives directory, leaving only index.html, twig and Serializer".

I think the command should be renamed to CleanTempFiles

@ywarnier
Copy link
Member Author

ywarnier commented Feb 7, 2014

Sorry, I just saw there is already a CleanTempFolder command, so the CleanDataFiles command should be renamed CleanCoursesFiles

@ywarnier ywarnier added the bug label Feb 13, 2014
@ywarnier
Copy link
Member Author

OK, the cleantempfolder also deletes the archive directory itself! Passing to "bug"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant