Fix failure to resolve changeset CLI in GitHub Actions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Feb 15, 2021
| @@ -181,20 +182,16 @@ export async function runVersion({ | |||
| let [versionCommand, ...versionArgs] = script.split(/\s+/); | |||
| await exec(versionCommand, versionArgs, { cwd }); | |||
| } else { | |||
| let changesetsCliPkgJson = await require(require.resolve( | |||
| "@changesets/cli/package.json", | |||
| { paths: [cwd] } | |||
There was a problem hiding this comment.
Why not just call fs.realpathSync just like it does and avoid the dependency?
https://github.com/sindresorhus/resolve-from/blob/4f02820afe9b4e9c379f4bb2745debdb49087d4f/index.js#L16
There was a problem hiding this comment.
Same reason as mentioned in #67: tests and robustness. This module is small and is well-used and well tested in the npm ecosystem (it's already present in yarn.lock here, for instance). Also the full code from resolve-from is:
let fromDirectory = cwd
try {
fromDirectory = fs.realpathSync(fromDirectory)
} catch (error) {
if (error.code === 'ENOENT') {
fromDirectory = path.resolve(fromDirectory)
} else {
throw error
}
}
Andarist
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #67 broke the action for me for projects that don't use Yarn 2 / PnP. It appears that the issue is that in an Actions environment, the root workspace directory is not a real directory, so it causes issues with a plain
require.resolve. When testing the action locally, I didn't catch this error since the workspace directory wasn't a symlink.This PR uses
resolve-fromto locate the changeset CLI, like the other PR originally did, as that module has code to work around symlinked directories.I can confirm that this branch works for my non-Yarn-PnP projects.