Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve distinction bewtween selected and unselected prompt items #811

Merged
merged 2 commits into from May 30, 2022

Conversation

samrose3
Copy link
Contributor

@samrose3 samrose3 commented May 21, 2022

Fixes #809

Two alternative ways to distinguish between selected and unselected prompt items.

Radio on and off

This is the method that is implemented.

radio-icons

Check and no icon

This is to demonstrate another alternative.

check-and-no-icon

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

🦋 Changeset detected

Latest commit: aa98378

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa98378:

Sandbox Source
Vanilla Configuration

@Andarist Andarist merged commit c54c25d into changesets:main May 30, 2022
4 checks passed
@Andarist
Copy link
Member

Andarist commented May 30, 2022

Thank you very much!

@github-actions github-actions bot mentioned this pull request May 30, 2022
@glasser
Copy link
Contributor

glasser commented Jun 9, 2022

Thank you! I am colorblind and the previous version was completely unusable for me. I came to this repo to do exactly the same thing and got quite confused when the source on main seemed to show radioOn and radioOff. Took a while of "where exactly does this get converted into checkmarks" before thinking to compare to my installed version :) Really looking forward to this being in a release!

@Andarist
Copy link
Member

Andarist commented Jun 11, 2022

@glasser I've just merged the versioning PR - this should be available shortly

@glasser
Copy link
Contributor

glasser commented Jun 13, 2022

Yay, I can verify that it makes the CLI significantly more usable for me. Thanks!

@samrose3 samrose3 deleted the alt-prompt-indicator branch Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use an alternative indicator for selecting packages
3 participants