Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added skipStrokeQuiz #317

Merged
merged 2 commits into from
May 23, 2024
Merged

feat: Added skipStrokeQuiz #317

merged 2 commits into from
May 23, 2024

Conversation

vherrmann
Copy link
Contributor

This feature adds a function skipStrokeQuiz, that can be used while in a quiz to skip a stroke. This is useful for e.g. 圖, since hanzi writer has a hard time recognizing the short strike under the upper inner box of
clipboard

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (4ec4eda) to head (63c209a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   96.41%   96.43%   +0.01%     
==========================================
  Files          32       32              
  Lines        1144     1149       +5     
  Branches      212      214       +2     
==========================================
+ Hits         1103     1108       +5     
  Misses         37       37              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chanind
Copy link
Owner

chanind commented May 23, 2024

Thanks for contributing this! I tweaked the API slightly so it's called skipQuizStroke, and added test coverage.

@chanind chanind merged commit b5c0d39 into chanind:master May 23, 2024
1 check passed
@chanind
Copy link
Owner

chanind commented May 23, 2024

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vherrmann
Copy link
Contributor Author

Nice! Thanks for the quick response (and the project in general)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants