Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip testing branch preemptive deletion #173

Merged
merged 1 commit into from
Aug 23, 2022

Commits on Aug 23, 2022

  1. skip "testing" branch preemptive deletion

    In #134, we transitioned from testing on `testing/<id>` instead of just
    `testing`.  In order to maintain backwards compatibility, we had to delete
    `testing` every time we created a new `testing/<id>` branch.
    
    That has been a month ago, and most projects that use Hoff should have had at
    least one PR triggering the deletion of `testing`.  So we should remove this
    code that tries deletion every time.
    
    We currently see the following in the logs every time we merge:
    
    ```haskell
    Aug 18 13:37:12 hoff hoff[4321]: [Warn] error: git push -d failed. Reason: error: unable to delete 'testing': remote ref does not exist
    Aug 18 13:37:29 hoff hoff[4321]: error: failed to push some refs to 'git@github.com:<org>/<repo>.git'
    ```
    
    This should get rid of entries like the above.
    rudymatela committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    7d58a61 View commit details
    Browse the repository at this point in the history