Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid O(n^2) time broadcast' by replacing Writer #112

Merged
merged 3 commits into from
May 9, 2023
Merged

Avoid O(n^2) time broadcast' by replacing Writer #112

merged 3 commits into from
May 9, 2023

Commits on May 9, 2023

  1. Don't sort the broadcast' test results 

    This prevents us from making sure the order doesn't change when
`broadcast'` is modified.
    @robbert-vdh
    robbert-vdh committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9d443e1 View commit details
    Browse the repository at this point in the history

  2. Avoid O(n^2) time broadcast' by replacing Writer 

    With the strict state monad we can prepend the items to a list and then
reverse the list afterwards to maintain the original order. This brings
the time complexity down from `O(n^2)` (because of the mappend/list
concatenation used by Writer) to `O(n)`.

Resolves #102.
    @robbert-vdh
    robbert-vdh committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c525dcc View commit details
    Browse the repository at this point in the history

  3. Merge #112: Avoid O(n^2) time broadcast' by replacing Writer 

    Approved-by: robbert-vdh
Auto-deploy: false
    @OpsBotPrime
    OpsBotPrime committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a24b517 View commit details
    Browse the repository at this point in the history