Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the default offset(GNB_WIDTH) in Toast #2116

Closed
sungik-choi opened this issue Mar 25, 2024 · 0 comments · Fixed by #2117
Closed

Remove the default offset(GNB_WIDTH) in Toast #2116

sungik-choi opened this issue Mar 25, 2024 · 0 comments · Fixed by #2117
Assignees
@sungik-choi
Labels
enhancement Issues or PR related to making existing features better

Comments

@sungik-choi
Copy link
Contributor

sungik-choi commented Mar 25, 2024 •
edited
Loading

Description

Remove the default offset(GNB_WIDTH) in Toast

Reasons for suggestion

데스크 애플리케이션에 의존하는 값을 디자인 시스템 라이브러리에서 기본값으로 둘 필요가 없습니다.

Proposed solution

제거하고, 데스크의 사용처에서 직접 offset을 정의하여 사용합니다.

References
@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Mar 25, 2024
@sungik-choi sungik-choi self-assigned this Mar 25, 2024
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Mar 25, 2024
@sungik-choi sungik-choi changed the title Remove the offset(GNB_WIDTH) in Toast Remove the default offset(GNB_WIDTH) in Toast Mar 25, 2024
@sungik-choi sungik-choi mentioned this issue Mar 25, 2024
Merged
6 tasks
sungik-choi added a commit that referenced this issue Mar 26, 2024
@sungik-choi
fix(toast): remove the default offset(GNB_OFFSET, 68) (#2117)
c15dddd 
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

- Fixes #2116 

## Summary

<!-- Please brief explanation of the changes made -->

Remove the default offset value in Toast

## Details

<!-- Please elaborate description of the changes -->

Toast 컴포넌트에서 기본값으로 가지고 있던, 채널 데스크 애플리케이션 종속적인 left offset 상수를 기본값에서
제거합니다.

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

Yes. 필요한 경우 사용처에서 직접 `left: 68` 값을 주어 사용해야합니다.
@github-project-automation github-project-automation bot moved this from 📌 Backlog to ✅ Done in Bezier React Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungik-choi sungik-choi

Labels
enhancement Issues or PR related to making existing features better
Projects
No open projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(toast): remove the default offset(GNB_OFFSET, 68) sungik-choi/bezier-react
1 participant
@sungik-choi