Install Playwright browsers #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuth
force-pushed
the
ah-playwright-browsers
branch
from
cc3d429
to
81bbed2
Compare
booc0mtaco
reviewed
Nov 8, 2023
| @@ -30,8 +30,5 @@ jobs: | |||
| - name: Prepare for Integration Tests | |||
| run: npm run demo:build | |||
|
|
|||
| - name: Install playwright browsers | |||
There was a problem hiding this comment.
Does this mean that some other thing installs chromium? The change description and this removal seem to say opposite things at first glance
There was a problem hiding this comment.
The @playwright/browser-chromium dep in package.json installs chromium automatically now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
This PR automatically installs Chromium and adds a note for installing other browsers.