Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't dowload too many annotation metadata files #639

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

jgadling
Copy link
Contributor

This is the fix for #628 and prevents download_all_annotations() from downloading metadata files for annotations that are filtered out by shape or format filters.

@jgadling jgadling requested a review from manasaV3 April 12, 2024 17:49
@jgadling jgadling changed the title Don't dowload too many annotation metadata files fix: Don't dowload too many annotation metadata files Apr 12, 2024
Copy link
Collaborator

@kandarpksk kandarpksk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@manasaV3 manasaV3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jgadling jgadling merged commit 69d9a68 into main Apr 15, 2024
12 of 13 checks passed
@jgadling jgadling deleted the jgadling/628-skip-unnecessary-metadata-download branch April 15, 2024 19:56
kne42 added a commit that referenced this pull request Apr 27, 2024
* main: (36 commits)
  feat: navigation styling updates (#614)
  feat: add section titles (#612)
  docs: Copying FAQ page to the docsite + adding copy to FAQ on docsite + adding AWS CLI page (#647)
  feat: shift dataset photo (#613)
  chore(main): release web 1.5.0 (#672)
  fix: use aws sync for dataset or all annotations download dialogs (#671)
  feat: implement author name legend (#625)
  chore(main): release web 1.4.1 (#670)
  fix: Adding liveliness_timeout and readiness_timeout  (#669)
  chore(main): release web 1.4.0 (#618)
  feat: release single annotation download annotation modal (#668)
  perf: measure getBrowseDatasets query perf (#667)
  fix: Updating annotation object shape type query (#666)
  ci: fix download modal e2e tests (#665)
  fix: annotation table primary author sort (#649)
  fix: Raise exception when attempting to filter on related objects. (#642)
  chore: Updating client for new db fields (#634)
  fix: Don't dowload too many annotation metadata files (#639)
  Update bug.md
  chore: Update bug.md (#641)
  ...
kne42 added a commit that referenced this pull request Apr 27, 2024
* main: (28 commits)
  feat: navigation styling updates (#614)
  feat: add section titles (#612)
  docs: Copying FAQ page to the docsite + adding copy to FAQ on docsite + adding AWS CLI page (#647)
  feat: shift dataset photo (#613)
  chore(main): release web 1.5.0 (#672)
  fix: use aws sync for dataset or all annotations download dialogs (#671)
  feat: implement author name legend (#625)
  chore(main): release web 1.4.1 (#670)
  fix: Adding liveliness_timeout and readiness_timeout  (#669)
  chore(main): release web 1.4.0 (#618)
  feat: release single annotation download annotation modal (#668)
  perf: measure getBrowseDatasets query perf (#667)
  fix: Updating annotation object shape type query (#666)
  ci: fix download modal e2e tests (#665)
  fix: annotation table primary author sort (#649)
  fix: Raise exception when attempting to filter on related objects. (#642)
  chore: Updating client for new db fields (#634)
  fix: Don't dowload too many annotation metadata files (#639)
  Update bug.md
  chore: Update bug.md (#641)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants