Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task runtime: revise input file mounting scheme #245

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Sep 30, 2019

Mount the input files under the container working directory, so that they're always in a directory to which the command has read/write access, even though the individual files are (by default) read-only. Then the task can create files alongside the index files and output them (e.g. samtools/tabix index files).

Mount all input files into one flat directory to the extent possible (barring filename collisions), also improving compatibility with index file handling assumptions.

Expose copy_input_files through run_local_workflow and CLI.

@mlin mlin force-pushed the mlin-mount-inputs-in-workdir branch from 85185f1 to 17c93d6 Compare September 30, 2019 22:41
@coveralls
Copy link

coveralls commented Sep 30, 2019

Pull Request Test Coverage Report for Build 1155

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 96.946%

Files with Coverage Reduction New Missed Lines %
WDL/runtime/task.py 15 95.51%
Totals Coverage Status
Change from base Build 1148: 0.008%
Covered Lines: 4381
Relevant Lines: 4519

💛 - Coveralls

@mlin mlin force-pushed the mlin-mount-inputs-in-workdir branch from 17c93d6 to 0299ae1 Compare September 30, 2019 23:46
@mlin mlin force-pushed the mlin-mount-inputs-in-workdir branch from 0299ae1 to 53821b5 Compare October 1, 2019 00:13
@mlin mlin merged commit 3b62bfc into master Oct 1, 2019
@mlin mlin deleted the mlin-mount-inputs-in-workdir branch October 2, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants