Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner: close logging FileHandlers #302

Merged
merged 3 commits into from
Nov 25, 2019
Merged

runner: close logging FileHandlers #302

merged 3 commits into from
Nov 25, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 24, 2019

No description provided.

@coveralls
Copy link

coveralls commented Nov 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1401

  • 104 of 107 (97.2%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 96.888%
Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/runtime/workflow.py 62 65 95.38%
Files with Coverage Reduction New Missed Lines %
WDL/runtime/task.py 2 95.62%
Totals Coverage Status
Change from base Build 1395: -0.01%
Covered Lines: 4732
Relevant Lines: 4884
💛 - Coveralls

@mlin mlin merged commit ad90d50 into master Nov 25, 2019
@mlin mlin deleted the mlin-close-filehandlers branch November 25, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlin @coveralls