Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework typechecking of optional/nonempty quantifiers #52

Merged
merged 6 commits into from
Dec 4, 2018

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Dec 4, 2018

Removes a few awkward workarounds / special cases for static validation of optional & nonempty type compatibility. They are now checked more rigorously by default, so for example any use of T? where T is expected requires an explicit coercion such as with select_first(). But to accommodate older WDLs which depend on less strictness, supplying WDL.load(..., check_quant=False) relaxes these static validation checks.

The WDL specification is vague as to how strict this typechecking should be; this compromise should let us accommodate older WDLs without necessarily reproducing every detail of what Cromwell does and doesn't enforce for different language versions

@coveralls
Copy link

coveralls commented Dec 4, 2018

Pull Request Test Coverage Report for Build 238

  • 75 of 77 (97.4%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 94.61%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/StdLib.py 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
WDL/Expr.py 1 95.81%
Totals Coverage Status
Change from base Build 224: 0.03%
Covered Lines: 1966
Relevant Lines: 2078

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 232

  • 65 of 67 (97.01%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/StdLib.py 14 16 87.5%
Totals Coverage Status
Change from base Build 224: 0.01%
Covered Lines: 1960
Relevant Lines: 2072

💛 - Coveralls

@mlin mlin merged commit 155e23d into master Dec 4, 2018
@mlin mlin deleted the mlin-rework-quant-checking2 branch February 15, 2019 04:40
@mlin mlin restored the mlin-rework-quant-checking2 branch February 15, 2019 04:40
@mlin mlin deleted the mlin-rework-quant-checking2 branch February 15, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants