Skip to content

Commit

Permalink
addressed docstring nits
Browse files Browse the repository at this point in the history
  • Loading branch information
klai95 committed Apr 24, 2023
1 parent fdd6496 commit 209bee2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions data-workflows/activity/github_activity_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ def __eq__(self, other):


def transform_and_write_to_dynamo(data: dict[str, List], activity_type: GitHubActivityType) -> None:
"""
Transforms plugin commit data generated by get_plugins_commit_count_since_timestamp to the expected format
"""Transforms plugin commit data generated by get_plugins_commit_count_since_timestamp to the expected format
and then writes the formatted data to the corresponding github-activity dynamo table in each environment
:param dict[str, list] data: plugin commit data of type dictionary in which the key is plugin name
of type str and the value is Github activities of type list
Expand Down
3 changes: 1 addition & 2 deletions data-workflows/activity/snowflake_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def get_plugins_with_commits_in_window(start_millis: int, end_millis: int) -> di

def get_plugins_commit_count_since_timestamp(plugins_by_earliest_ts: dict[str, datetime],
github_activity_type: GitHubActivityType) -> dict[str, List]:
"""
This method gets the commit data since a specific starting point for each plugin.
"""This method gets the commit data since a specific starting point for each plugin.
If GitHubActivityType.LATEST, fetch the latest commit timestamp, so construct query without commit count constraint
If GitHubActivityType.MONTH, fetch the sum of commits from the beginning of the month of the timestamp specified
for each of the plugin.
Expand Down

0 comments on commit 209bee2

Please sign in to comment.