Seed categories script unit tests #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
added
the
maintenance
manasaV3
reviewed
May 17, 2023
manasaV3
requested changes
May 17, 2023
manasaV3
previously approved these changes
May 31, 2023
Comment on lines
+38
to
+43
| def _get_category_from_model(category): | ||
| return { | ||
| "label": category.label, | ||
| "dimension": category.dimension, | ||
| "hierarchy": category.hierarchy, | ||
| } |
codemonkey800
force-pushed
the
jeremy/seed-categories-script-tests
branch
from
9502b6f
to
d9c1c01
Compare
manasaV3
approved these changes
Jun 1, 2023
manasaV3
reviewed
Jun 6, 2023
| return category | ||
|
|
||
|
|
||
| def get_all_categories(version: str): |
There was a problem hiding this comment.
The caller of this method (ref here) still seems to be referencing it as if it were a class method for CategoryModel.
| } | ||
|
|
||
|
|
||
| def get_category(name: str, version: str): |
There was a problem hiding this comment.
The caller of this method (ref here) still seems to be referencing it as if it were a class method for CategoryModel.
We should update that reference to api.models.category.get_category(..).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description