-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure python versions are sorted #86
Conversation
Could someone link the issue? I want to reproduce to ensure the issue is actually fixed. 😆 |
@0x00b1 I think the order is messed up because we're using napari-hub/client/src/components/PluginSearch/PluginFilterByForm.tsx Lines 67 to 74 in 75e867e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for fixing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x00b1 This PR needs some work. See @codemonkey800 's comment #86 (comment)
hey @0x00b1 do you think you can land this or should @codemonkey800 or @kne42 pick it up? |
Previous Behavior: PR Updating the Docs: |
We may want to add a build step to automatically populate
SUPPORTED_PYTHON_VERSIONS
.We will need to provide a custom comparison function if we want to non-uniform version numbers (e.g.
3
and3.9.5
).