Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

[BUG] RCA Infinite Loop when KPI is query based #344

Closed
kartikay-bagla opened this issue Oct 27, 2021 · 1 comment
Closed

[BUG] RCA Infinite Loop when KPI is query based #344

kartikay-bagla opened this issue Oct 27, 2021 · 1 comment
Assignees
@kartikay-bagla
Labels
🧮 algorithms Core algorithms, optimization & ML model related 🛠️ backend 🐛 bug Something isn't working P1

Comments

@kartikay-bagla
Copy link
Contributor

Describe the bug

RCA can sometimes enter an infinite loop trying to find the last date for which data is available when KPI is defined as a query.
@kartikay-bagla kartikay-bagla self-assigned this Oct 27, 2021
@manassolanki manassolanki added P1 🐛 bug Something isn't working 🛠️ backend 🧮 algorithms Core algorithms, optimization & ML model related labels Oct 27, 2021
@kartikay-bagla
Copy link
Contributor Author

kartikay-bagla commented Oct 27, 2021 •
edited by manassolanki
Loading

To fix this issue we need to do 2 things:

  • Fix the while condition in _get_end_data_for_rca_kpi
  • Update the SQL query created for query based KPIs

kartikay-bagla added a commit that referenced this issue Oct 27, 2021
@kartikay-bagla
fix: fix infinite loop in #344
53f710b
manassolanki added a commit that referenced this issue Oct 27, 2021
@manassolanki
Merge pull request #345 from chaos-genius/fix-rca-kpi-query
fbc19c3 
fix: fixes #344 by removing infinite loop and updating kpi query code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kartikay-bagla kartikay-bagla

Labels
🧮 algorithms Core algorithms, optimization & ML model related 🛠️ backend 🐛 bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kartikay-bagla @manassolanki