Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make anomaly CSV download work for subdims too #1038

Merged
merged 7 commits into from
Jul 15, 2022
Merged

Make anomaly CSV download work for subdims too #1038

merged 7 commits into from
Jul 15, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Jul 13, 2022 •
edited

Changes

  • Added parameters dimension and value to the anomaly data download endpoint
  • Modified the function to optionally take a subdim dict
  • CSV name: added KPI name and date to it, but this did not take effect as the name is set from the frontend. The better names are only available when the API is invoked directly.
  • Minor changes: moved the function which gets data from anomaly_data_view.py to download_view.py (since it was used only in download_view.py), added some missing type annotations, added flake8 ignores for catch-all exceptions

@Samyak2 Samyak2 added this to the v0.10.0 milestone Jul 13, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jul 13, 2022

@netlify
Copy link

netlify bot commented Jul 13, 2022 •
edited

✅ Deploy Preview for frontend-sb ready!

Name Link
🔨 Latest commit 042553c
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62d0e4c5918b8f000989b3d4
😎 Deploy Preview https://deploy-preview-1038--frontend-sb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bhargavsk1077
bhargavsk1077 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@bhargavsk1077 bhargavsk1077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samyak2 Samyak2 added the don't merge PR which doesn't need to be merged right now label Jul 14, 2022
@Samyak2
Copy link
Contributor Author

Samyak2 commented Jul 14, 2022

Need to update this with the path sanitizer util from #1035

Amatullah
Amatullah approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@Amatullah Amatullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amatullah Amatullah merged commit bee0082 into develop Jul 15, 2022
@Amatullah Amatullah deleted the feat/anomaly-subdim-filter-csv branch July 15, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amatullah Amatullah Amatullah approved these changes

@bhargavsk1077 bhargavsk1077 Awaiting requested review from bhargavsk1077

Assignees
No one assigned
Labels
🛠️ backend don't merge PR which doesn't need to be merged right now 🖥️ frontend
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Samyak2 @Amatullah @bhargavsk1077 @ChartistDev