Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD port #27

Merged
merged 1 commit into from
May 8, 2016
Merged

FreeBSD port #27

merged 1 commit into from
May 8, 2016

Conversation

dverite
Copy link

@dverite dverite commented Apr 21, 2016

  • deal with lack of dirent.d_off on FreeBSD
  • make xattr* functions essentially no-ops
  • skip prctl() and setrlimit()
  • some differences in struct statfs
  • some mount options lacking
  • replace SOL_TCP by IPPROTO_TCP
  • use linux value for errno EOPNOTSUPP

- deal with lack of dirent.d_off on FreeBSD
- make xattr* functions essentially no-ops
- skip prctl() and setrlimit()
- some differences in struct statfs
- some mount options lacking
- replace SOL_TCP by IPPROTO_TCP
- use linux value for errno EOPNOTSUPP
@garlick
Copy link
Member

garlick commented Apr 24, 2016

Thanks for submitting this. What results do you get from make check on freebsd?

The os ifdefs should probably be converted to autoconf feature tests, however as that's tedious work and this projects build system needs a cleanup pass anyway we can probably defer that.

Is there a specific use case you are supporting here?

I'm about to check this out on my FreeNAS box but have to get a few things tweaked there first.

@garlick
Copy link
Member

garlick commented Apr 25, 2016

Never mind on the make check question - I see the tests need to be made tolerant of missing bits before we'll get anywhere with that. Still interested in your use case though.

@dverite
Copy link
Author

dverite commented Apr 25, 2016

Some specific autoconf checks would be a nice addition, notably for setfsuid/gid and xattrs.
Currently autoreconf fails for me on FreeBSD, I've built from a pre-autoconf'ed+make dist archive on Linux.
Use case: the user is a hosting service that has lots of ZFS volumes on FreeBSD: diod/9p is considered as an alternative to NFS (linux client/server on FreeBSD), and also to native ZFS on Linux.

@garlick
Copy link
Member

garlick commented May 8, 2016

I'll go ahead and merge this and we can follow up with the cleanup later.

@garlick garlick merged commit 0ea3fe3 into chaos:master May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants