Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regex pattern parameter for servlet to minimize blast radius #177

Merged
merged 1 commit into from
Jun 22, 2021
Merged

add regex pattern parameter for servlet to minimize blast radius #177

merged 1 commit into from
Jun 22, 2021

Conversation

arthur657834
Copy link
Contributor

Describe what this PR does / why we need it

add regex pattern parameter for servlet to minimize blast radius

Does this pull request fix one issue?

Fixes #176

Describe how you did it

Describe how to verify it

./blade create servlet modifyCode --code 500 --requestpath-regex-pattern /greeting/2* -d
./blade create servlet modifyCode --code 500 --querystring-regex-pattern name=1* -d

Special notes for reviews

Signed-off-by: arthur657834 <kingkom7834@126.com>
@xcaspar
Copy link
Member

xcaspar commented Jun 22, 2021

Good idea!! Thanks for your contributions!

@xcaspar xcaspar self-requested a review June 22, 2021 00:52
@xcaspar xcaspar added the type/feature Category issues or prs related to feature request. label Jun 22, 2021
@xcaspar xcaspar added this to the v1.3.0 milestone Jun 22, 2021
@xcaspar xcaspar merged commit 0beb568 into chaosblade-io:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add servlet regex pattern filter to minimize blast radius
2 participants