Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error when destroying the network experiment #105

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Dec 16, 2021

Signed-off-by: xcaspar changjun.xcj@alibaba-inc.com

Describe what this PR does / why we need it

Solve the problem of using the --force flag to return a RTNETLINK answers: Invalid argument\\nWe have an error talking to the kernel error.

Does this pull request fix one issue?

Describe how you did it

Use uid equal to 0 to determine the execution authority.

Describe how to verify it

Package and test it.

# ./blade c network delay --interface eth0 --time 20
{"code":200,"success":true,"result":"b09acbf1e9c5617e"}
# ./blade c network delay --interface eth0 --time 20 --local-port 80 --force
{"code":200,"success":true,"result":"0bfdf627300c4c35"}

Special notes for reviews

Signed-off-by: xcaspar <changjun.xcj@alibaba-inc.com>
@xcaspar xcaspar added the type/bug Something isn't working label Dec 16, 2021
@xcaspar xcaspar added this to the v1.5.0 milestone Dec 16, 2021
@xcaspar xcaspar merged commit 07c5107 into master Dec 16, 2021
@MandssS MandssS deleted the network-destroy-bug branch July 26, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant