fix: Modify the absolute path execution of musl-gcc #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Super-long <0x4f4f4f4f@gmail.com>
Super-long
force-pushed
the
fix-makefile-musl
branch
from
585c994
to
ff53558
Compare
tiny-x
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
musl-gcc is used when building nsexec in the Makefile, which uses absolute paths when executing, which is unnecessary. And doing so will fail to execute under some distributions. For example, in the PKGBUILD file of archLinux, /usr/bin/ is used as the storage path for executable files instead of /usr/local/.
Does this pull request fix one issue?
NONE
Describe how you did it
I changed the execution absolute path of musl-gcc to look for execution in $PATH.
Describe how to verify it
Just make directly.