-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation of enabling HTTPS for augur server #1542
Conversation
Signed-off-by: Sean Lee Brennan <brennansean6@gmail.com>
@sbrennan98 or @ABrain7710 or @IsaacMilarky : We need to test that this will run on a dev machine for a developer who runs the frontend using @Ulincsys : We would also need to update @ABrain7710 : Anything that can be scripted on install would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not requesting any changes from @sbrennan98 -- Thanks for the contribution!
I think the dev team just needs to sort out the different installation conditions. Of course, if @sbrennan98 wants to help, we will not refuse. :)
augur/application.py
Outdated
@@ -39,7 +39,9 @@ def __init__(self, given_config={}, disable_logs=False, offline_mode=False): | |||
self.gunicorn_options = { | |||
'bind': '%s:%s' % (self.config.get_value("Server", "host"), self.config.get_value("Server", "port")), | |||
'workers': int(self.config.get_value('Server', 'workers')), | |||
'timeout': int(self.config.get_value('Server', 'timeout')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ABrain7710 : This is the section of the code with the merge conflict. @sbrennan98 has a useful comment when you look at the merge conflict, and I think its these conditions where the install script may need to be modified. If we could script generating a certbot certificate (I'm not sure we can, or that its worth the labor), then we may want to use config variables for HTTP or HTTPS.
@sgoggins does this needs contribution? I saw this on the projects top priorities list |
Enabling HTTPS for an Augur Server
This change includes some files and documentation for enabling HTTPS to work with augur :)