Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of enabling HTTPS for augur server #1542

Merged
merged 23 commits into from
Apr 13, 2022

Conversation

sbrennan98
Copy link
Contributor

Enabling HTTPS for an Augur Server

This change includes some files and documentation for enabling HTTPS to work with augur :)

@sgoggins sgoggins added add-feature Adds new features server Related to the Augur server labels Feb 4, 2022
@sgoggins sgoggins linked an issue Feb 4, 2022 that may be closed by this pull request
@sgoggins
Copy link
Member

sgoggins commented Feb 4, 2022

@sbrennan98 or @ABrain7710 or @IsaacMilarky : We need to test that this will run on a dev machine for a developer who runs the frontend using npm run serve ... I think it does, but would like some confirmation.

@Ulincsys : We would also need to update augur_view to hit https endpoints.

@ABrain7710 : Anything that can be scripted on install would be great.

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not requesting any changes from @sbrennan98 -- Thanks for the contribution!
I think the dev team just needs to sort out the different installation conditions. Of course, if @sbrennan98 wants to help, we will not refuse. :)

@@ -39,7 +39,9 @@ def __init__(self, given_config={}, disable_logs=False, offline_mode=False):
self.gunicorn_options = {
'bind': '%s:%s' % (self.config.get_value("Server", "host"), self.config.get_value("Server", "port")),
'workers': int(self.config.get_value('Server', 'workers')),
'timeout': int(self.config.get_value('Server', 'timeout'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ABrain7710 : This is the section of the code with the merge conflict. @sbrennan98 has a useful comment when you look at the merge conflict, and I think its these conditions where the install script may need to be modified. If we could script generating a certbot certificate (I'm not sure we can, or that its worth the labor), then we may want to use config variables for HTTP or HTTPS.

@sgoggins sgoggins changed the base branch from main to spg-patch-abf April 13, 2022 18:25
@sgoggins sgoggins merged commit 9a011fd into chaoss:spg-patch-abf Apr 13, 2022
sgoggins added a commit that referenced this pull request Apr 14, 2022
This reverts commit 9a011fd, reversing
changes made to a42171e.
@ayushtamra
Copy link

ayushtamra commented Apr 21, 2022

@sgoggins does this needs contribution? I saw this on the projects top priorities list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-feature Adds new features server Related to the Augur server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use https in the website
4 participants