Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstring to organize_needed_data #1601

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Add docstring to organize_needed_data #1601

merged 2 commits into from
Jan 31, 2022

Conversation

ABrain7710
Copy link
Contributor

  1. Remove the table_pkey param because it is unneeded. The table_pkey is obtained in the get_relevant_columns method so it does not need to be passed in as a parameter.
  2. Add docstring to organize_needed_data method

@ABrain7710
Remove unneeded table_pkey method param
b57e20a 
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
@ABrain7710
Add doc string for organize_needed_data
864fdaf 
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
@sgoggins sgoggins merged commit bbe72ff into main Jan 31, 2022
@ABrain7710 ABrain7710 deleted the andrew-organize-needed-data branch February 2, 2022 14:59
sgoggins added a commit that referenced this pull request Feb 4, 2022
@sgoggins
Revert "Trying to still fix:"
7c1fc15 
This reverts commit dd9376e.

I think this commit missed teh importance of table_pkey: #1601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABrain7710 @sgoggins