-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Pull Request, Facade, and Contributor Logic #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac M <krabs@tilde.team>
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Worker git integration refactor
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
2022-02-04 03:03:53,131,131ms [PID: 957399] workers.pull_request_worker.50471 [INFO] No more pages to check, breaking from pagination. 2022-02-04 03:03:53,131,131ms [PID: 957399] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() got multiple values for argument 'in_memory' Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() got multiple values for argument 'in_memory' 2022-02-04 03:03:53,160,160ms [PID: 957399] workers.pull_request_worker.50471 [INFO] Worker completed this task in -72.24467587471008 seconds. 2022-02-04 03:03:53,172,172ms [PID: 957399] workers.pull_request_worker.50471 [INFO] Recorded job completion for: {'worker_id': 'workers.pull_request_worker.50471', 'job_type': 'MAINTAIN', 'repo_id': 27044, 'job_model': 'pull_requests', 'github_url': 'https://github.com/vmware/clarity'}
2022-02-04 03:10:32,904,904ms [PID: 1000904] workers.pull_request_worker.50471 [INFO] No more pages to check, breaking from pagination. 2022-02-04 03:10:32,904,904ms [PID: 1000904] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() got an unexpected keyword argument 'in_memory' Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() got an unexpected keyword argument 'in_memory' 2022-02-04 03:10:32,933,933ms [PID: 1000904] workers.pull_request_worker.50471 [INFO] Worker completed this task in -70.22280406951904 seconds. 2022-02-04 03:10:32,944,944ms [PID: 1000904] workers.pull_request_worker.50471 [INFO] Recorded job completion for: {'worker_id': 'workers.pull_request_worker.50471', 'job_type': 'MAINTAIN', 'repo_id': 27044, 'job_model': 'pull_requests', 'github_url': 'https://github.com/vmware/clarity'}
22-02-04 03:22:31,750,750ms [PID: 1239046] workers.pull_request_worker.50471 [INFO] Updated rate limit, you have: 4674 requests remaining. 2022-02-04 03:22:31,755,755ms [PID: 1239046] workers.pull_request_worker.50471 [INFO] Analyzation of page 28 of 28 complete 2022-02-04 03:22:31,755,755ms [PID: 1239046] workers.pull_request_worker.50471 [INFO] No more pages to check, breaking from pagination. 2022-02-04 03:22:31,755,755ms [PID: 1239046] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given 2022-02-04 03:22:31,785,785ms [PID: 1239046] workers.pull_request_worker.50471 [INFO] Worker completed this task in -71.99200201034546 seconds.
2022-02-04 03:30:39,971,971ms [PID: 1278984] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given 2022-02-04 03:30:40,000,0ms [PID: 1278984] workers.pull_request_worker.50471 [INFO] Worker completed this task in -70.00859665870667 seconds. 2022-02-04 03:30:40,019,19ms [PID: 1278984] workers.pull_request_worker.50471 [INFO] Recorded job completion for: {'worker_id': 'workers.pull_request_worker.50471', 'job_type': 'MAINTAIN', 'repo_id': 27044, 'job_model': 'pull_requests', 'github_url': 'https://github.com/vmware/clarity'}
2022-02-04 03:30:39,971,971ms [PID: 1278984] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given 2022-02-04 03:30:40,000,0ms [PID: 1278984] workers.pull_request_worker.50471 [INFO] Worker completed this task in -70.00859665870667 seconds. 2022-02-04 03:30:40,019,19ms [PID: 1278984] workers.pull_request_worker.50471 [INFO] Recorded job completion for: {'worker_id': 'workers.pull_request_worker.50471', 'job_type': 'MAINTAIN', 'repo_id': 27044, 'job_model': 'pull_requests', 'github_url': 'https://github.com/vmware/clarity'}
2022-02-04 03:30:39,971,971ms [PID: 1278984] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given 2022-02-04 03:30:40,000,0ms [PID: 1278984] workers.pull_request_worker.50471 [INFO] Worker completed this task in -70.00859665870667 seconds. 2022-02-04 03:30:40,019,19ms [PID: 1278984] workers.pull_request_worker.50471 [INFO] Recorded job completion for: {'worker_id': 'workers.pull_request_worker.50471', 'job_type': 'MAINTAIN', 'repo_id': 27044, 'job_model': 'pull_requests', 'github_url': 'https://github.com/vmware/clarity'}
2022-02-04 03:50:11,016,16ms [PID: 1542143] workers.pull_request_worker.50471 [DEBUG] Pull Requests model. ERROR: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given Traceback (most recent call last): File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/bigdisk/augur-vmware/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/bigdisk/augur-vmware/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( TypeError: organize_needed_data() takes from 3 to 4 positional arguments but 5 were given 2022-02-04 03:50:11,046,46ms [PID: 1542143] workers.pull_request_worker.50471 [INFO] Worker completed this task in -64.56478452682495 seconds. I'm running out of logical guesses about what broke here.
This reverts commit 57e08e8.
2022-02-03 21:56:37,984,984ms [PID: 492008] workers.pull_request_worker.9099 [INFO] No more pages to check, breaking from pagination. 2022-02-03 21:56:37,985,985ms [PID: 492008] workers.pull_request_worker.9099 [DEBUG] Pull Requests model. ERROR: name 'in_memory' is not defined Traceback (most recent call last): File "/home/sean/github/opsfirst/workers/pull_request_worker/pull_request_worker.py", line 723, in pull_requests_model pk_source_prs = self._get_pk_source_prs() File "/home/sean/github/opsfirst/workers/pull_request_worker/pull_request_worker.py", line 676, in _get_pk_source_prs source_prs = self.paginate_endpoint( File "/home/sean/github/opsfirst/workers/worker_git_integration.py", line 1274, in paginate_endpoint need_insertion, need_update = self.organize_needed_data( File "/home/sean/github/opsfirst/workers/worker_persistance.py", line 409, in organize_needed_data if not in_memory: NameError: name 'in_memory' is not defined 2022-02-03 21:56:37,986,986ms [PID: 492008] workers.pull_request_worker.9099 [INFO] Worker completed this task in -1.6014952659606934 seconds.
sgoggins
commented
Feb 22, 2022
@@ -91,8 +91,10 @@ test: test-application test-metric-routes test-workers | |||
test-application: | |||
@ bash -c 'tox -e py-application' | |||
|
|||
#Worker's tests need a database from docker | |||
#To use the docker daemon you need to be root so sudo is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a modification of to one API endpoint.